Merged
Conversation
SBCOSS-467: Sunbird Groups service - add the GitHub actions to run test cases and code quality checks when a PR raised
SBCOSS-468: Sunbird Groups service - create Github actions to publish docker image to GHCR
To fix the docker image name which is pushed to GHCR
Issue #SBCOSS-548: Vulnerability fixes
Issue #SBCOSS-385 fix: Vulnerability fixes in groups-service
- These fields were removed to return all the keys and values that will be read from the `search-service`
Issue #SBCOSS-00: Remove fields from activityConfig.json to remove bgms hardcoding
Co-authored-by: sntiwari1 <54884367+sntiwari1@users.noreply.github.com>
Co-authored-by: sntiwari1 <54884367+sntiwari1@users.noreply.github.com>
Co-authored-by: sntiwari1 <54884367+sntiwari1@users.noreply.github.com>
Co-authored-by: sntiwari1 <54884367+sntiwari1@users.noreply.github.com>
….0.2 Co-authored-by: sntiwari1 <54884367+sntiwari1@users.noreply.github.com>
Co-authored-by: sntiwari1 <54884367+sntiwari1@users.noreply.github.com>
…ME.md Co-authored-by: sntiwari1 <54884367+sntiwari1@users.noreply.github.com>
Removed dependency verification and testing recommendations sections from the upgrade documentation.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…eTest.scala Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
SBCOSS-677: Fixed existing Test Cases
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
SB-I320: Fixed membership update api call
Upgrade to Play Framework 3.0.5 and Apache Pekko 1.0.3
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the groups-service from Play Framework 2.7.2 with Akka 2.5.22 to Play Framework 3.0.5 with Apache Pekko 1.0.3, addressing licensing concerns and modernizing the technology stack.
Key Changes:
- Migrated from Akka (Business Source License) to Apache Pekko 1.0.3 (Apache 2.0 license)
- Upgraded Play Framework from 2.7.2 to 3.0.5
- Upgraded Scala from 2.12.11 to 2.13.12 and associated dependencies (SLF4J, Logback, Jackson, Netty)
- Added new utility classes for Scala/Java collection interoperability
- Updated configuration files to use Pekko namespaces instead of Akka
- Added GitHub Actions workflows for CI/CD with code coverage and SonarQube integration
Reviewed changes
Copilot reviewed 45 out of 46 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Updated parent POM with new dependency versions for Pekko, Play 3.0, Scala 2.13, logging, and other core libraries |
| service/pom.xml | Updated service dependencies, changed Play groupId to org.playframework, added JAXB dependencies, updated repository URLs, and added JVM module access flags for Java 11+ |
| sb-actor/pom.xml | Migrated from Akka to Pekko actor dependencies |
| group-actors/pom.xml | Updated Pekko testkit dependencies and added JVM module access flags |
| cassandra-utils/pom.xml | Added JVM module access flags for test execution |
| sb-utils/pom.xml | Added JVM module access flags for test execution |
| service/conf/application.conf | Replaced akka configuration blocks with pekko namespaces and updated secret key |
| service/app/controllers/BaseController.java | Updated imports from akka to pekko and changed FutureConverters.toJava() to asJava() |
| service/app/controllers/ResponseHandler.java | Enhanced exception handling to support both BaseException and other exception types |
| service/app/utils/module/*.java | Updated stream and actor imports from akka to pekko |
| service/test/controllers/*.java | Updated all test imports from akka to pekko |
| service/app/validators/*.java | Enhanced to handle both Java and Scala collections with new conversion utilities |
| sb-utils/src/main/java/org/sunbird/util/CollectionConverterUtil.java | New utility class for converting Scala collections to Java collections using reflection |
| group-actors/src/main/java/org/sunbird/actors/*.java | Updated all imports from akka to pekko |
| group-actors/src/main/java/org/sunbird/dao/GroupDaoImpl.java | Enhanced updateGroup to use TypeReference and filter null values |
| group-actors/src/main/java/org/sunbird/util/*.java | Updated to use collection converter utilities and pekko imports |
| group-actors/src/test/java/org/sunbird/actors/*.java | Updated test imports from akka to pekko and added @ignore to CreateGroupActorTest |
| group-actors/src/main/resources/activityConfig.json | Emptied the fields array from activity configuration |
| platform-cache/src/test/scala/org/sunbird/cache/impl/RedisCacheTest.scala | Updated ScalaTest imports for 3.x compatibility |
| platform-cache/src/main/scala/org/sunbird/cache/util/RedisConnector.scala | Added Platform import |
| .github/workflows/*.yml | Added CI/CD workflows for PR code coverage and build/deploy automation |
| .github/*.md | Added documentation for coverage and build processes |
| UPGRADE_README.md | Added comprehensive upgrade documentation explaining the migration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sntiwari1
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.